Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an adapter for the HTTP ruby gem.
I copied a lot from how the Net::HTTP adapter works.
This adapter is a bit difficult, because the HTTP gem has a perform method on its client that takes in a request, builds the connection, and executes it. This means there's not a great way to instantiate a client with a host/port, assert things about its semian_options, and then later actually execute the request.
Typical usage is to call something like
HTTP.get(url)
, which uses this get method, which runs HTTP::Client.new.request(verb, uri).HTTP::Client.new
takes anoptions
argument, but it's just timeout / ssl settings. Nothing regarding the URI.If anyone has ideas on how to better test that, please let me know. I've run this code in my own project, and it's working well.