Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to example docs #547

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Conversation

bostonaholic
Copy link
Contributor

@bostonaholic bostonaholic commented Aug 26, 2024

A couple of minor mistakes I found in the docs when working through an implementation of dynamic sub resources.

  1. ActiveSupport::CurrentAttributes is the correct class docs [code]
  2. sub_resourece_name was assigned but then name was shoveled incorrectly [code]
  3. Using attribute :name will result in infinite recursion, presumably due to it trying to override the .name class method [code]

@bostonaholic bostonaholic changed the title Minor fixes to example Minor fixes to example docs Aug 27, 2024
Copy link
Contributor

@atraver-shopify atraver-shopify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping things tidy! Just a minor typo on the variable name.

README.md Outdated Show resolved Hide resolved
@bostonaholic bostonaholic force-pushed the bostonaholic/fix-dynamic-example branch from b2132d2 to cb73050 Compare August 29, 2024 14:27
@bostonaholic
Copy link
Contributor Author

bostonaholic commented Aug 29, 2024

/shipit

oops, habit

@bostonaholic bostonaholic merged commit d7c89d2 into main Aug 29, 2024
42 checks passed
@bostonaholic bostonaholic deleted the bostonaholic/fix-dynamic-example branch August 29, 2024 14:36
@pjambet
Copy link
Contributor

pjambet commented Oct 23, 2024

Missed this, but thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants