Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove future flag for released feature #1705

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

zzooeeyy
Copy link
Contributor

@zzooeeyy zzooeeyy commented Oct 29, 2024

WHY are these changes introduced?

Closes:

When optional scopes feature is released, we have the option to either:

  • Enable scopes future flag by default for new apps and communicate to apps to enable this future flag to use Scopes API OR
  • Remove the future flag so that apps can use Scopes API automatically.

I think removing the future flag makes more sense since we're adding new feature and not modifying existing behaviour of the library.

WHAT is this pull request doing?

Removes future flag wip_optionalScopesApi.

Top hatting

I tested by linking my app to a local version of the remix library. I can use the Scopes API without adding the future flag.

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have used pnpm changeset to create a draft changelog entry (do NOT update the CHANGELOG.md files manually)
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

@zzooeeyy zzooeeyy marked this pull request as ready for review October 29, 2024 22:51
@zzooeeyy zzooeeyy requested a review from a team as a code owner October 29, 2024 22:51
Copy link
Contributor

@matteodepalo matteodepalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizkenyon
Copy link
Contributor

Just to confirm the docs for this feature is in this PR?

@zzooeeyy
Copy link
Contributor Author

Just to confirm the docs for this feature is in this PR?

@lizkenyon -- Yes, but we don't have to merge these until we're ready to release

Copy link

@kbav kbav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Zoey!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants