Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timeout for graphql requests #588

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alperenkaplan
Copy link

WHY are these changes introduced?

I realized that shopify servers sometimes doesn't respond and the code halts. Giving an optional timeout parameter would fix the issue.

WHAT is this pull request doing?

Adding an optional timeout parameter to the execute method of GraphQL Class in shopify/resources/graphql.py on line 18 and using that parameter on line 27.

Checklist

  • I have updated the CHANGELOG (if applicable)
  • [+] I have followed the Shopify Python guide

@ghost ghost added the cla-needed label Jun 22, 2022
@alperenkaplan alperenkaplan reopened this Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant