Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid JSON in /version endpoint response #538

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Fix invalid JSON in /version endpoint response #538

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5e164c
Fix invalid JSON in /version endpoint response
whatyouhide Oct 14, 2023
56c3f4b
Fix test
whatyouhide Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,7 @@ func (server *ApiServer) Version(response http.ResponseWriter, request *http.Req
log := zerolog.Ctx(request.Context())

response.Header().Set("Content-Type", "application/json;charset=utf-8")
version := fmt.Sprintf(`{"version": "%s"}\n`, Version)
version := fmt.Sprintf("{\"version\": \"%s\"}\n", Version)
_, err := response.Write([]byte(version))
if err != nil {
log.Warn().Err(err).Msg("Version: Failed to write response to client")
Expand Down
Loading