Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated go version to fix 3 CVEs #559

Merged
merged 8 commits into from
Mar 12, 2024
Prev Previous commit
Next Next commit
Adding the comment to ignore like in tests as its started to scan the…
…se errors
dianadevasia committed Mar 12, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit e20f3da62efa7ca687cbba0378ce066174712e81
2 changes: 1 addition & 1 deletion toxics/latency.go
Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@ func (t *LatencyToxic) delay() time.Duration {
delay := t.Latency
jitter := t.Jitter
if jitter > 0 {
//#nosec
// #nosec G404 -- was ignored before too
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the comment in the standard way as mentioned in the documentation.

delay += rand.Int63n(jitter*2) - jitter
}
return time.Duration(delay) * time.Millisecond
4 changes: 2 additions & 2 deletions toxics/slicer.go
Original file line number Diff line number Diff line change
@@ -38,9 +38,9 @@ func (t *SlicerToxic) chunk(start int, end int) []int {
}

mid := start + (end-start)/2
//#nosec

if t.SizeVariation > 0 {
mid += rand.Intn(t.SizeVariation*2) - t.SizeVariation
mid += rand.Intn(t.SizeVariation*2) - t.SizeVariation // #nosec G404 -- was ignored before too
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

golangci-lint was failing so had to add the comment on the same line

}
left := t.chunk(start, mid)
right := t.chunk(mid, end)
4 changes: 2 additions & 2 deletions toxics/toxic.go
Original file line number Diff line number Diff line change
@@ -81,8 +81,8 @@ func NewToxicStub(input <-chan *stream.StreamChunk, output chan<- *stream.Stream
func (s *ToxicStub) Run(toxic *ToxicWrapper) {
s.running = make(chan struct{})
defer close(s.running)
//#nosec
if rand.Float32() < toxic.Toxicity {
randomToxicity := rand.Float32() // #nosec G404 -- was ignored before too
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

golangci-lint was failing so had to add the comment on the same line

if randomToxicity < toxic.Toxicity {
toxic.Pipe(s)
} else {
new(NoopToxic).Pipe(s)