Save the size of ruby-lsp responses and verify against expected sizes #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting. The first call is returning nil on CI. So that's another vote in favour of "sometimes this fails and we don't notice." |
noahgibbs
force-pushed
the
ruby_lsp_verify
branch
from
c32b62e
to
5d5f1de
Compare
noahgibbs
force-pushed
the
ruby_lsp_verify
branch
from
3439f76
to
f735017
Compare
Also update the parser gem to avoid a ruby-lsp/rubocop-related bug.
noahgibbs
force-pushed
the
ruby_lsp_verify
branch
from
f735017
to
a88f55a
Compare
|
At this point, I think this is good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presumably the results will be the same on x86 or ARM. If they're not, that's a really interesting result...
Fixes #239.