Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TruffleRuby in CI #251

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Add TruffleRuby in CI #251

merged 2 commits into from
Sep 18, 2023

Conversation

eregon
Copy link
Contributor

@eregon eregon commented Sep 18, 2023

It would be nice if benchmarks also ran a single iteration on TruffleRuby in CI.
Currently all benchmarks pass after #250

If some new benchmark does not work on truffleruby or there is some issue with a benchmark on truffleruby it would be fine to just exclude that benchmark on truffleruby, the goal is not to prevent merging benchmarks which do not work on truffleruby but just raise awareness if a change to yjit-bench does not work on TruffleRuby.

@eregon
Copy link
Contributor Author

eregon commented Sep 18, 2023

Actually I think it'd be good to test on the latest CRuby release too, to make sure benchmark run fine there too, I pushed a commit for that.

@noahgibbs
Copy link
Contributor

noahgibbs commented Sep 18, 2023

Currently failing for TruffleRuby in CI due to a StackOverflowError, looks like a line that calls itself:

from org.truffleruby.language.methods.TranslateExceptionNodeGen.executeTranslation(TranslateExceptionNodeGen.java:112)
	from org.truffleruby.language.RubyMethodRootNode.execute(RubyMethodRootNode.java:99)
/home/runner/.rubies/truffleruby-head/lib/gems/bundler/gems/rails-4e01a7e8753c/activesupport/lib/active_support/descendants_tracker.rb:60:in `subclasses'
	from /home/runner/.rubies/truffleruby-head/lib/gems/bundler/gems/rails-4e01a7e8753c/activesupport/lib/active_support/descendants_tracker.rb:61:in `subclasses'
	from /home/runner/.rubies/truffleruby-head/lib/gems/bundler/gems/rails-4e01a7e8753c/activesupport/lib/active_support/descendants_tracker.rb:61:in `subclasses'
	from /home/runner/.rubies/truffleruby-head/lib/gems/bundler/gems/rails-4e01a7e8753c/activesupport/lib/active_support/descendants_tracker.rb:61:in `subclasses'
	from /home/runner/.rubies/truffleruby-head/lib/gems/bundler/gems/rails-4e01a7e8753c/activesupport/lib/active_support/descendants_tracker.rb:61:in `subclasses'
	from /home/runner/.rubies/truffleruby-head/lib/gems/bundler/gems/rails-4e01a7e8753c/activesupport/lib/active_support/descendants_tracker.rb:61:in `subclasses'
	from /home/runner/.rubies/truffleruby-head/lib/gems/bundler/gems/rails-4e01a7e8753c/activesupport/lib/active_support/descendants_tracker.rb:61:in `subclasses'

@eregon
Copy link
Contributor Author

eregon commented Sep 18, 2023

Yes, that's fixed by #250, I didn't include these commits again here to make the diff easier to review. Will rebase once that's merged.


- name: Run tests
run: ruby test/*_test.rb
run: ruby test/benchmarks_test.rb
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @k0kubun ruby test/*_test.rb only works with a single file, with more files the 2nd and later files would just be user arguments, so I changed to this for clarity.

@maximecb maximecb merged commit 049f182 into Shopify:main Sep 18, 2023
3 of 4 checks passed
@eregon eregon deleted the truffleruby-ci branch September 18, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants