-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TruffleRuby in CI #251
Conversation
Actually I think it'd be good to test on the latest CRuby release too, to make sure benchmark run fine there too, I pushed a commit for that. |
Currently failing for TruffleRuby in CI due to a StackOverflowError, looks like a line that calls itself:
|
Yes, that's fixed by #250, I didn't include these commits again here to make the diff easier to review. Will rebase once that's merged. |
|
||
- name: Run tests | ||
run: ruby test/*_test.rb | ||
run: ruby test/benchmarks_test.rb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @k0kubun ruby test/*_test.rb
only works with a single file, with more files the 2nd and later files would just be user arguments, so I changed to this for clarity.
It would be nice if benchmarks also ran a single iteration on TruffleRuby in CI.
Currently all benchmarks pass after #250
If some new benchmark does not work on truffleruby or there is some issue with a benchmark on truffleruby it would be fine to just exclude that benchmark on truffleruby, the goal is not to prevent merging benchmarks which do not work on truffleruby but just raise awareness if a change to yjit-bench does not work on TruffleRuby.