Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize to one version of Bundler #252

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

XrXr
Copy link
Contributor

@XrXr XrXr commented Sep 21, 2023

There are two benefits to this. One, older bundlers printed an annoying DidYouMean deprecation message. Two, since bundler self-installs the version that the lock file is bundled with, standardizing to one version speeds up bootstraping the suite.

I can also add a CI check here if desired.

There are two benefits to this. One, older bundlers printed an annoying
DidYouMean deprecation message. Two, since bundler self-installs the
version that the lock file is bundled with, standardizing to one version
speeds up bootstraping the suite.
Copy link
Contributor

@maximecb maximecb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alan :)

@XrXr XrXr merged commit 6aee7ed into Shopify:main Sep 21, 2023
4 checks passed
@XrXr XrXr deleted the one-bundler-version branch September 21, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants