Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harness-perf: Use -o only for perf record #285

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

k0kubun
Copy link
Member

@k0kubun k0kubun commented Feb 23, 2024

The -o option in harness-perf is useful because only some benchmarks use Dir.chdir and you might end up reading perf.data of other benchmarks without it. So it's useful for perf record, however, I want the output of perf stat to go to stdout as it normally does.

This PR changes the harness to add -o option only when it's used with PERF=record.

@k0kubun k0kubun marked this pull request as ready for review February 23, 2024 23:36
@maximecb maximecb merged commit 98568c8 into Shopify:main Feb 26, 2024
4 checks passed
@k0kubun k0kubun deleted the perf-o branch February 26, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants