Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer Review for Project 2 #22

Closed
wants to merge 3 commits into from
Closed

Peer Review for Project 2 #22

wants to merge 3 commits into from

Conversation

bgosal02
Copy link
Contributor

@bgosal02 bgosal02 commented Feb 5, 2025

Ignore the "overlapping components" verification error.

Copy link

github-actions bot commented Feb 5, 2025

Thank you for your pull request! 👋

Copy link

github-actions bot commented Feb 5, 2025

Welcome, new contributor!

Thank you for uploading your design.

If you have not already checked it, please run the SiEPIC Functional Verification in KLayout, using the menu SiEPIC-Verification-Functional Layout Check (V).

You may continue making updates to your design, or even contributing additonal designs (using a separate file name), until the tape-out deadline.

@lukasc-ubc
Copy link
Member

  • connect the input to the on-chip laser, at (0,10)
  • the ∆L looks too small

Copy link

Welcome, new contributor!

Thank you for uploading your design.

If you have not already checked it, please run the SiEPIC Functional Verification in KLayout, using the menu SiEPIC-Verification-Functional Layout Check (V).

You may continue making updates to your design, or even contributing additonal designs (using a separate file name), until the tape-out deadline.

Copy link

Thank you for your pull request! 👋

Copy link

Thank you for your pull request! 👋

@bgosal02 bgosal02 closed this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants