Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chip 2 Final submission #59

Merged
merged 16 commits into from
Feb 12, 2025
Merged

Chip 2 Final submission #59

merged 16 commits into from
Feb 12, 2025

Conversation

gillrobyn
Copy link
Contributor

I have removed the old files I had previously submitted, and have submitted 2 versions of Chip2 as well as an updated draft report. On my end it does not appear there are any outstanding verification issues.

Copy link

Thank you for your pull request! 👋

@Hang-Bobby-Zou
Copy link
Collaborator

Please fix the top cell name as well as opt_in label, the labels are the same for v03 and v04. Can I also ask why do you have identical designs? What is the purpose of it?

@gillrobyn
Copy link
Contributor Author

Can you clarify, what should the TOP cell name be?

v03 has three identical MZIs to study the MFG tolerance across the chip
v04 has one target MZI plus 2 variants that have +/- 1% length difference in delta L

@Hang-Bobby-Zou
Copy link
Collaborator

TOP cell should be named: ELEC413_ or something.
v03: you are not going to get too useful of a data since they are very close to each other
v04: ok

Copy link

Thank you for your pull request! 👋

Copy link

Thank you for your pull request! 👋

Copy link

Thank you for your pull request! 👋

@gillrobyn
Copy link
Contributor Author

Thank you for all the feedback, I have updated both layout files and deleted the old ones.
I believe I have corrected the opt_in labels to all be unique across both files
I believe the TOP cell is now named correctly for each file
I have spaced out the MZIs in v03 to get a better idea of performance vs. placement on the chip.
Please let me know if you have additional feedback.

@lukasc-ubc
Copy link
Member

you have a v03 and v04 file. Do you want to fabricate both? Or just one.
I'll merge it, but you can remove one in a new PR.

@lukasc-ubc lukasc-ubc merged commit 6c187b3 into SiEPIC:main Feb 12, 2025
4 of 5 checks passed
@gillrobyn
Copy link
Contributor Author

Yes! The intent is to fabricate both versions if that's okay, they are slightly different. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants