Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EBeam_Shreya314 #147

Merged
merged 18 commits into from
Oct 13, 2024
Merged

EBeam_Shreya314 #147

merged 18 commits into from
Oct 13, 2024

Conversation

Roundy808
Copy link
Contributor

New pull request, updated files

Roundy808 added 12 commits October 2, 2024 17:03
@Roundy808
Add files via upload
228107f
@Roundy808
EBeam_Shreya314
6165779 
2 GDS files with separate tiles
@Roundy808
3rd attempt
da689d1 
GDS submission
@Roundy808
Merge branch 'SiEPIC:main' into main
6cbf614
@Roundy808
Add files via upload
188688d 
There were additional top cells displayed which have been deleted in this version
@Roundy808
Add files via upload
cfd0c80 
There were additional top cells (noticed after peer review) that have been deleted in this file
@Roundy808
Add files via upload
d7770d5 
Additional top cells removed after peer review
@Roundy808
Add files via upload
960055e
@Roundy808
Add files via upload
1380bb8 
Additional top cells deleted after peer review
@Roundy808
Merge pull request #2 from Roundy808/Roundy808-submission1
cc532a6 
Add files via upload
@Roundy808
Merge pull request #1 from Roundy808/Roundy808-submission
722d3db 
Submission of design
@Roundy808
Merge branch 'SiEPIC:main' into main
96d474f
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

Thank you for your pull request! Staff will review your submission, and if it passes all checks, it will be merged. After merging, you may check the merged file. 👋

@lukasc-ubc
Copy link
Member

Error: Cell bounding box / extent (630.86, 372.44) is larger than the maximum size of 605.0 X 410.0 microns
1
Errors detected: EBeam_Shreya314.gds, 1 errors. EBeam_Shreya314_Tile1.gds, 1 errors. EBeam_Shreya314_Tile1v2.gds, 1 errors. EBeam_Shreya314_Tile2.gds, 1 errors. EBeam_Shreya314_Tile2v2.gds, 1 errors.

@lukasc-ubc lukasc-ubc added the bug Something isn't working label Oct 9, 2024
@github-actions GitHub Actions
Copy link

Thank you for your pull request! 👋

@github-actions GitHub Actions
Copy link

Thank you for your pull request! 👋

@github-actions GitHub Actions
Copy link

Thank you for your pull request! 👋

@github-actions GitHub Actions
Copy link

Thank you for your pull request! 👋

@Roundy808
Box size fixed (Tile1)
2201fbd 
Floor box size fixed as per bug report
@github-actions GitHub Actions
Copy link

Thank you for your pull request! 👋

@Roundy808
Box size fixed (Tile 2)
43e2d97 
Box size fixed according to bug report
@github-actions GitHub Actions
Copy link

Thank you for your pull request! 👋

@Roundy808
Copy link
Contributor Author

I have fixed the size of the box on the floor level. Thank you for noticing it.
Requesting design to be approved and merged to EBeam.gds

@Roundy808
Copy link
Contributor Author

Error: Cell bounding box / extent (630.86, 372.44) is larger than the maximum size of 605.0 X 410.0 microns 1 Errors detected: EBeam_Shreya314.gds, 1 errors. EBeam_Shreya314_Tile1.gds, 1 errors. EBeam_Shreya314_Tile1v2.gds, 1 errors. EBeam_Shreya314_Tile2.gds, 1 errors. EBeam_Shreya314_Tile2v2.gds, 1 errors.

Thank you Lukas. This has been fixed now

@Roundy808
Copy link
Contributor Author

Please ignore the layout verification error. It works on my PC without any errors.

@omidesml omidesml merged commit fc2671e into SiEPIC:main Oct 13, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Roundy808 @lukasc-ubc @omidesml