Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First Draft #31

Merged
merged 6 commits into from
Feb 3, 2025
Merged

First Draft #31

merged 6 commits into from
Feb 3, 2025

Conversation

paigejh13
Copy link
Contributor

No description provided.

Copy link

Welcome, new contributor!

Thank you for uploading your design.

If you have not already checked it, please run the SiEPIC Functional Verification in KLayout, using the menu SiEPIC-Verification-Functional Layout Check (V).

You may continue making updates to your design, or even contributing additonal designs (using a separate file name), until the tape-out deadline.

Copy link

Thank you for your pull request! 👋

@omidesml
Copy link
Collaborator

omidesml commented Feb 1, 2025

This will not merge. Fix the gds file name.

The filename contains your edX or GitHub username (if the edX one is a random string that does not contain your name), and be formatted according to the course/workshop as follows:
EBeam_username.oas: for the [edX Phot1x silicon photonics design course]
ELEC413_username.oas: for the [UBC ELEC 413 course]
SiEPIC_Passives_username.oas: for the [CMC SiEPIC Passives silicon photonics workshop]
openEBL_username.gds: for past participants in the above courses

Also change the opt_in lablels to include your name and device name. It's too generic

image

Copy link

github-actions bot commented Feb 3, 2025

Thank you for your pull request! 👋

Copy link

github-actions bot commented Feb 3, 2025

Welcome, new contributor!

Thank you for uploading your design.

If you have not already checked it, please run the SiEPIC Functional Verification in KLayout, using the menu SiEPIC-Verification-Functional Layout Check (V).

You may continue making updates to your design, or even contributing additonal designs (using a separate file name), until the tape-out deadline.

Copy link

github-actions bot commented Feb 3, 2025

Welcome, new contributor!

Thank you for uploading your design.

If you have not already checked it, please run the SiEPIC Functional Verification in KLayout, using the menu SiEPIC-Verification-Functional Layout Check (V).

You may continue making updates to your design, or even contributing additonal designs (using a separate file name), until the tape-out deadline.

Copy link

github-actions bot commented Feb 3, 2025

Thank you for your pull request! 👋

Copy link

github-actions bot commented Feb 3, 2025

Thank you for your pull request! 👋

Copy link

github-actions bot commented Feb 3, 2025

Welcome, new contributor!

Thank you for uploading your design.

If you have not already checked it, please run the SiEPIC Functional Verification in KLayout, using the menu SiEPIC-Verification-Functional Layout Check (V).

You may continue making updates to your design, or even contributing additonal designs (using a separate file name), until the tape-out deadline.

Copy link

github-actions bot commented Feb 3, 2025

Welcome, new contributor!

Thank you for uploading your design.

If you have not already checked it, please run the SiEPIC Functional Verification in KLayout, using the menu SiEPIC-Verification-Functional Layout Check (V).

You may continue making updates to your design, or even contributing additonal designs (using a separate file name), until the tape-out deadline.

Copy link

github-actions bot commented Feb 3, 2025

Thank you for your pull request! 👋

@omidesml omidesml merged commit abac96a into SiEPIC:main Feb 3, 2025
2 checks passed
@omidesml omidesml mentioned this pull request Feb 4, 2025
@omidesml
Copy link
Collaborator

omidesml commented Feb 4, 2025

Please resubmit under main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants