Simplify RHP4 DevEx #233
Open
Simplify RHP4 DevEx #233
+11
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjan
reviewed
Nov 18, 2024
| @@ -98,9 +107,9 @@ func (hp HostPrices) RPCReadSectorCost(length uint64) Usage { | |||
|
|
|||
| // RPCWriteSectorCost returns the cost of executing the WriteSector RPC with the | |||
| // given sector length and duration. | |||
| func (hp HostPrices) RPCWriteSectorCost(sectorLength uint64, duration uint64) Usage { | |||
| func (hp HostPrices) RPCWriteSectorCost(sectorLength uint64) Usage { | |||
There was a problem hiding this comment.
nit update docstring to reflect change
ChrisSchinnerl
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces two changes to simplify client DX. These settings felt very similar to the batch size settings in RHP2 -- the host could technically change them, but actual renter code just assumed the default 17.83 MB was valid. This enforces a safe default assumption and reduces potential complexity around hosts with differing settings.