Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure #19

Merged
merged 6 commits into from
May 14, 2024
Merged

Restructure #19

merged 6 commits into from
May 14, 2024

Conversation

n8maninger
Copy link
Member

@n8maninger n8maninger commented May 4, 2024

Goals:

  • Keep the "v1" and "v2" logic as isolated as possible
  • Make struct namespacing more logical
  • Remove "small" modules
  • Cleanup

So far:

  • Moved "core" types into a common crate-level module
  • Readded the namespacing for most modules
  • Moved "v1" signing logic into the v1 transaction struct 🤢
  • Moved all UnlockConditions logic into the unlock_conditions module
  • Everything should be returning a Hash256 instead of a [u8;32]
  • Refactored some of the unwrap calls
  • Added a specifier macro and removed the generic From because it was causing me problems

Looking for other suggestions to make this lib more consistent and developer-friendly

src/seed.rs Outdated Show resolved Hide resolved
src/seed.rs Show resolved Hide resolved
src/spendpolicy.rs Outdated Show resolved Hide resolved
src/spendpolicy.rs Outdated Show resolved Hide resolved
@n8maninger n8maninger marked this pull request as ready for review May 12, 2024 03:04
@ChrisSchinnerl ChrisSchinnerl merged commit b204084 into master May 14, 2024
1 check passed
@ChrisSchinnerl ChrisSchinnerl deleted the nate/restructure branch May 14, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants