Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move transaction signing to signing state #46

Closed
wants to merge 1 commit into from
Closed

Move transaction signing to signing state #46

wants to merge 1 commit into from

Conversation

n8maninger
Copy link
Member

@n8maninger n8maninger commented Aug 16, 2024 •
edited
Loading

No description provided.

ChrisSchinnerl
ChrisSchinnerl reviewed Aug 16, 2024
View reviewed changes
Copy link
Member

@ChrisSchinnerl ChrisSchinnerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for this change? I kinda like having the sig hash creation on the transaction. Felt pretty natural to use.

src/spendpolicy.rs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no more spend policy?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spend policies are json encoded now, most of this was broken

@n8maninger n8maninger closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisSchinnerl ChrisSchinnerl ChrisSchinnerl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n8maninger @ChrisSchinnerl