New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move encoding/mod.rs to /encoding.rs #59

Closed

ChrisSchinnerl wants to merge 1 commit into master from chris/remove-mod-rs

Member

ChrisSchinnerl commented Nov 4, 2024 •

edited

Loading

According to the Rust Book, using mod.rs for declaring modules with sub-modules is deprecated.

Note: Prior to rustc 1.30, using mod.rs files was the way to load a module with nested children. It is encouraged to use the new naming convention as it is more consistent, and avoids having many files named mod.rs within a project.

So I'm quickly updating the one occurrence we got to make sure we stick to the new convention right away before adding more mod.rs files.


          encoding: move encoding/mod.rs to /encoding.rs

95e2769

ChrisSchinnerl changed the title ~~encoding: move encoding/mod.rs to /encoding.rs~~ Move encoding/mod.rs to /encoding.rs

ChrisSchinnerl requested a review from n8maninger

November 4, 2024 06:25

ChrisSchinnerl self-assigned this

Member

n8maninger commented Nov 6, 2024

Closing in favor of #57

n8maninger closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet