HMAC added #32
HMAC added #32
Conversation
src/handlers/auth_handlers.rs
Outdated
| @@ -188,6 +196,30 @@ pub async fn login_handler( | |||
| }) | |||
| } | |||
|
|
|||
| fn generate_secure_token() -> (String, String) { | |||
There was a problem hiding this comment.
I think it will be better if you create a new file in /utils for functions related to hmac.
This file should only contain routes.
There was a problem hiding this comment.
Ohh okay,
Is the overall functionality of the code, I written is good ?
There was a problem hiding this comment.
It seems fine!!. I have got to test it. If you happen to test the route, provide us with details
src/handlers/auth_handlers.rs
Outdated
| use rand::Rng; | ||
| use base64::{Engine as _, engine::general_purpose}; | ||
|
|
||
| const HMAC_SECRET: &[u8] = b"your-secret-key-here"; |
There was a problem hiding this comment.
Store secrets in src/utils/constants and then import them here.
There was a problem hiding this comment.
Oh sorry for blunder
|
run |
Cargo.toml
Outdated
| @@ -25,6 +25,7 @@ serde = "1.0.197" | |||
| serde_json = "1.0.114" | |||
| chrono = "0.4.38" | |||
| sea-orm = { version = "1.0.0-rc.5", features = [ "sqlx-postgres", "runtime-tokio-rustls", "macros" ] } | |||
| sqlx = { version = "0.5", features = [ "postgres", "runtime-tokio-rustls" ] } | |||
There was a problem hiding this comment.
btw, why are you adding sqlx as a dependency tho?
There was a problem hiding this comment.
I was trying to setup the db, and on cli, I don't know why but sqlx error was coming so I added it.
I forgot to review. I will remove it.
|
@ShashwatAgrawal20 , |
closes #21