Improve Error Handling for parse() in get_user_by_id_handler and update_contest_score_handler #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced `unwrap()` with proper error handling for parsing ID - Return 400 Bad Request if ID parsing fails - Return detailed error message if database query fails - Added handling for case when user is not found in the database
- Replaced `unwrap()` with robust error handling for ID parsing - Return 400 Bad Request if ID parsing fails - Added error handling for database update failures - Improved response messages for missing user cases
|
Great work!! @HarshitShukla-dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #4 by improving error handling in the
get_user_by_id_handlerandupdate_contest_score_handlerfunctions, which previously used.parse().unwrap()to convert a string to an integer. The use of.unwrap()could cause the application to panic if the string was not a valid integer. To prevent this, I have replaced.parse().unwrap()with proper error handling that checks the result of theparse()operation.In the
get_user_by_id_handlerfunction, ID parsing is now handled with proper error checking instead of usingunwrap(). If the parsing fails, a400 Bad Requestresponse is returned, providing a clear error message. Additionally, the function now responds with a404 Not Foundstatus when no user is found in the database.Similarly, in the
update_contest_score_handler, ID parsing is improved with proper error handling, returning a400 Bad Requestresponse for invalid input. The function also handles database update failures more gracefully and returns more descriptive responses when the user is missing.