-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added svelte example for xlsx-import #157
Conversation
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 54 54
Lines 1061 1061
Branches 153 153
=========================================
Hits 1061 1061
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Thank you @Metastasis 🥇 |
I still remember and partially reviewed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally, I reviewed it ;) Thank you for your contribution. Looks great to me 🥇
I tested it locally, and I run tests, all works.
I'm a little bit confused about the result of npm run validate
, which return a set of errors with types that seem unable to work. (As You linked pyoner/svelte-typescript#23 ). I have to consider what should we do with that fact. I guess may we use just ES without TS? (TypeScript without typing imports seem to be fiction ;) )
WDYT?
a4a8f23
to
1ef05fd
Compare
@Metastasis Great job :-) Thank you, Types are working now;) |
a554b6f
to
87b0c17
Compare
@Metastasis Thank you very much for that great contribution 👍 |
Description
Resolves Svelte example from #6
EDIT @Siemienik :