Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make the entire row clickable in logs quick filters #6574

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Dec 2, 2024

Summary

  • currently only the chevron icon was clickable to expand and collpase the quick filters in logs.
  • made the entire row clickable for expand and collapse for better experience

Related Issues / PR's

contributes to - #6572

Screenshots

Screen.Recording.2024-12-03.at.12.08.22.AM.mov

Affected Areas and Manually Tested Areas

  • quick filters in logs

Important

Make entire row clickable for expand/collapse in logs quick filters, enhancing user experience.

  • Behavior:
    • Entire row in filter-header-checkbox is now clickable for expand/collapse in Checkbox.tsx.
    • Clear All button click event now stops propagation to prevent row toggle.
  • Styles:
    • Added cursor: pointer to .filter-header-checkbox in Checkbox.styles.scss to indicate clickable area.

This description was created by Ellipsis for 2de8dac. It will automatically update as commits are pushed.

@github-actions github-actions bot added the chore label Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25 vikrantgupta25 marked this pull request as ready for review December 2, 2024 18:39
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 2de8dac in 25 seconds

More details
  • Looked at 67 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. frontend/src/components/QuickFilters/FilterRenderers/Checkbox/Checkbox.tsx:412
  • Draft comment:
    The cursor="pointer" on the chevron icon is redundant since the entire row is now clickable. Consider removing it for clarity.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR aims to make the entire row clickable for expanding and collapsing the quick filters. The change involves moving the click handler from the chevron icon to the entire row. However, the chevron icon still has a cursor style applied, which is now redundant since the entire row is clickable.
2. frontend/src/components/QuickFilters/FilterRenderers/Checkbox/Checkbox.tsx:414
  • Draft comment:
    The cursor="pointer" on the chevron icon is redundant since the entire row is now clickable. Consider removing it for clarity. This applies to both ChevronDown and ChevronRight icons.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR introduces a click handler on the entire row, but the chevron icons still have a cursor style applied, which is now redundant. This is also applicable to the ChevronRight icon.
3. frontend/src/components/QuickFilters/FilterRenderers/Checkbox/Checkbox.tsx:412
  • Draft comment:
    Avoid using inline styles for the cursor property. Use CSS classes or styled components instead. This applies to line 414 as well.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_xvSRR3YZNfM7jVy2


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@vikrantgupta25 vikrantgupta25 enabled auto-merge (squash) December 2, 2024 18:47
@vikrantgupta25 vikrantgupta25 merged commit 43f856c into develop Dec 3, 2024
21 of 23 checks passed
@YounixM YounixM deleted the responsive-dropdown branch December 3, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants