-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: celery overview page #6918
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
cbd4221
to
e784fba
Compare
1953bbe
to
10dfdb2
Compare
c23bd3e
to
e48223c
Compare
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to e48223c in 1 minute and 40 seconds
More details
- Looked at
1051
lines of code in21
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. frontend/src/AppRoutes/routes.ts:414
- Draft comment:
The component for the routeMESSAGING_QUEUES_CELERY_OVERVIEW
should beCeleryOverview
instead ofMessagingQueues
. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The pattern in the code shows MessagingQueues being used as a container component for multiple messaging queue related routes. This is likely intentional where the component internally handles different views based on the route. The comment suggests breaking this pattern without strong evidence that it's incorrect. Additionally, there's no evidence that a CeleryOverview component even exists in the codebase.
I could be wrong if there's a specific architectural decision that Celery-related views should use separate components, or if the MessagingQueues component isn't properly handling the Celery overview case.
Without seeing strong evidence of either of those cases, and given the clear pattern of using MessagingQueues for other messaging queue routes including another Celery route, the current implementation appears intentional and correct.
The comment should be deleted as it suggests breaking an established pattern without strong evidence that the current implementation is wrong.
2. frontend/src/components/CeleryOverview/CeleryOverviewConfigOptions/CeleryOverviewConfigOptions.styles.scss:21
- Draft comment:
Use design tokens or predefined color constants instead of hardcoding color values for consistency. This is also applicable in other stylesheets likeCeleryOverviewTable.styles.scss
andCeleryOverview.styles.scss
. - Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_3vEELARp8eRJjEQG
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
frontend/src/components/CeleryOverview/CeleryOverviewTable/CeleryOverviewTable.tsx
Show resolved
Hide resolved
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 60281c4 in 30 seconds
More details
- Looked at
86
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. frontend/src/components/CeleryTask/CeleryTaskGraph/CeleryTaskGraphUtils.ts:536
- Draft comment:
TheceleryTaskLatencyWidgetData
function is duplicated. Consider removing the first instance to avoid confusion and maintain code clarity. - Reason this comment was not posted:
Comment looked like it was already resolved.
2. frontend/src/components/CeleryTask/CeleryTaskGraph/CeleryTaskGraphGrid.tsx:69
- Draft comment:
Avoid using inline styles in React components. Use external stylesheets, CSS classes, or styled components instead. This applies to the entire file. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_ex2EJVGgHMJbuS5v
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
...nd/src/components/CeleryOverview/CeleryOverviewConfigOptions/CeleryOverviewConfigOptions.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on ed45628 in 15 seconds
More details
- Looked at
13
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. frontend/src/components/CeleryTask/CeleryTaskGraph/CeleryTaskGraphUtils.ts:572
- Draft comment:
The change to use '{{celery.task_name}}' for the legend improves clarity by dynamically displaying the task name. This is a good enhancement for the Celery Overview Page. - Reason this comment was not posted:
Confidence changes required:10%
The change in the legend field is straightforward and aligns with the intent of the PR to improve the Celery Overview Page.
Workflow ID: wflow_L4yG67O8t4diCP32
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Summary
Added Celery Overview Page
Related Issues / PR's
Screenshots
Screen.Recording.2025-01-27.at.10.19.04.AM.mov
Affected Areas and Manually Tested Areas
Important
Add Celery Overview page with new components, routes, and API integration for displaying Celery task data.
CeleryOverview
component inCeleryOverview.tsx
to display Celery task overview.getQueueOverview
API ingetQueueOverview.ts
to fetch queue data.CeleryOverviewConfigOptions.tsx
usinguseCeleryFilterOptions
.MESSAGING_QUEUES_CELERY_OVERVIEW
inroutes.ts
andAppRoutes/pageComponents.ts
.MessagingQueuesMainPage.tsx
to include Celery Overview tab.CeleryOverview.styles.scss
,CeleryOverviewConfigOptions.styles.scss
, andCeleryOverviewTable.styles.scss
.routePermission
inutils/permission/index.ts
to includeMESSAGING_QUEUES_CELERY_OVERVIEW
.This description was created by for ed45628. It will automatically update as commits are pushed.