Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: changed the traces tab query to incorporate span scopes #6922

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

eKuG
Copy link
Contributor

@eKuG eKuG commented Jan 26, 2025

Summary

Related Issues / PR's

Related PR : #6810

Screenshots

NA

Affected Areas and Manually Tested Areas


Important

Incorporated span scopes into trace query building logic and updated related tests and constants.

  • Behavior:
    • Updated buildTracesQuery in query_builder.go (v3 and v4) to incorporate span scopes in trace queries.
    • Adjusted SQL query templates to include span scope filters.
  • Tests:
    • Updated query_builder_test.go (v3 and v4) to test new span scope logic in trace queries.
  • Constants:
    • Modified TracesExplorerViewSQLSelectWithSubQuery and TracesExplorerViewSQLSelectAfterSubQuery in constants.go to support span scope queries.

This description was created by Ellipsis for 4bd0c68. It will automatically update as commits are pushed.

@github-actions github-actions bot added the enhancement New feature or request label Jan 26, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 6699f7e in 32 seconds

More details
  • Looked at 54 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. pkg/query-service/app/traces/v4/query_builder_test.go:649
  • Draft comment:
    The test cases for Test_buildTracesQuery should include scenarios that test the new span scope logic. Consider adding tests that verify the behavior when span scope filters like isRoot and isEntryPoint are used.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_SsfKpNN2BBzsksHp


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@eKuG eKuG enabled auto-merge (squash) January 26, 2025 14:25
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 4bd0c68 in 25 seconds

More details
  • Looked at 39 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. pkg/query-service/app/traces/v3/query_builder_test.go:1168
  • Draft comment:
    The expected query for the NoOp trace view test case should include the filterSubQuery to reflect the changes made in the PR. Ensure the test case is updated to match the new query logic.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. pkg/query-service/app/traces/v3/query_builder.go:353
  • Draft comment:
    Avoid using the component/index.tsx file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.

Workflow ID: wflow_TdYqo40SorjCSibQ


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@eKuG eKuG requested a review from nityanandagohain January 26, 2025 14:40
@nityanandagohain
Copy link
Member

please add description about what you are doing and why

@eKuG
Copy link
Contributor Author

eKuG commented Jan 27, 2025

please add description about what you are doing and why

Fixes this problem @nityanandagohain
https://signoz-team.slack.com/archives/C089D1B5516/p1737689540397439?thread_ts=1737647631.385699&cid=C089D1B5516

@eKuG eKuG merged commit 6dc7a76 into main Jan 27, 2025
16 checks passed
@eKuG eKuG deleted the feat/change-trace-tab-query branch January 27, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs shipped enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants