Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: metrics explorer base setup #7024

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

amlannandy
Copy link
Member

@amlannandy amlannandy commented Feb 4, 2025

Summary

Setup the basic structure for Metrics Explorer with 1 page having 3 tabs (Summary, Explorer, Views)

Related Issues / PR's

N/A

Screenshots

Screen.Recording.2025-02-04.at.8.02.59.PM.mov

Affected Areas and Manually Tested Areas

N/A


Important

Sets up the basic structure for a new Metrics Explorer feature with three tabs and corresponding routes, components, and permissions.

  • Metrics Explorer Setup:
    • Adds MetricsExplorerPage with three tabs: Summary, Explorer, and Views in MetricsExplorerPage.tsx.
    • Implements Summary, Explorer, and Views components with error boundaries in respective tsx files.
    • Styles for the page added in MetricsExplorerPage.styles.scss.
  • Routing:
    • Adds routes for /metrics-explorer/summary, /metrics-explorer/explorer, and /metrics-explorer/views in routes.ts and constants/routes.ts.
    • Updates AppRoutes to include new MetricsExplorer routes.
  • Localization:
    • Adds titles for Metrics Explorer tabs in titles.json.
  • Permissions:
    • Grants ADMIN, EDITOR, and VIEWER roles access to new routes in utils/permission/index.ts.
  • Misc:
    • Sidebar menu item for Metrics Explorer is commented out in menuItems.tsx.

This description was created by Ellipsis for c5e4c1a. It will automatically update as commits are pushed.

@amlannandy amlannandy requested a review from YounixM as a code owner February 4, 2025 14:37
@github-actions github-actions bot added enhancement New feature or request docs required labels Feb 4, 2025
@@ -82,6 +82,13 @@ const menuItems: SidebarItem[] = [
label: 'Logs',
icon: <ScrollText size={16} />,
},
// TODO - Enable this when the metrics explorer feature is read for release
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only showing the side nav button in the recording. Have commented it out now.
Will enable it back once the feature is complete.

@amlannandy amlannandy force-pushed the feat/metrics-explorer-base-setup branch from c5e4c1a to 5525f59 Compare February 4, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs required enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant