fix: output callsignVhf with empty path

Fixes SignalK/signalk-server#1842.
SignalK · Dec 9, 2024 · d91e52a · d91e52a
1 parent 3b0401a
commit d91e52a
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 6 deletions.
diff --git a/pgns/129794.js b/pgns/129794.js
@@ -50,8 +50,13 @@ module.exports = [
     }
   },
   {
-    node: 'communication.callsignVhf',
-    source: 'Callsign'
+    node: '',
+    filter: n2k => n2k.fields['Callsign'],
+    value: n2k => ({
+      communication: {
+        callsignVhf: n2k.fields['Callsign']
+      }
+    })
   },
   {
     node: 'design.beam',

diff --git a/pgns/129810.js b/pgns/129810.js
@@ -26,8 +26,13 @@ module.exports = [
     source: 'Beam'
   },
   {
-    node: 'communication.callsignVhf',
-    source: 'Callsign'
+    node: '',
+    filter: n2k => n2k.fields['Callsign'],
+    value: n2k => ({
+      communication: {
+        callsignVhf: n2k.fields['Callsign']
+      }
+    })
   },
   {
     node: 'sensors.ais.fromBow',

diff --git a/test/129794_ais_class_a_static_data.js b/test/129794_ais_class_a_static_data.js
@@ -53,14 +53,22 @@ describe('129794 AIS Class A Static and Voyage Related Data', function () {
     const valuesWithEmptyPath = delta.updates[0].values.filter(
       pathValue => pathValue.path === ''
     )
-    valuesWithEmptyPath.length.should.equal(3)
+    valuesWithEmptyPath.length.should.equal(4)
     expect(valuesWithEmptyPath).to.have.deep.members([
       {
         path: '',
         value: {
           name: 'SILVER GWEN'
         }
       },
+      {
+        path: '',
+        value: {
+          communication: {
+            callsignVhf: '3FJJ4'
+          }
+        }
+      },
       {
         path: '',
         value: {
@@ -91,7 +99,6 @@ describe('129794 AIS Class A Static and Voyage Related Data', function () {
     )
     tree.should.have.nested.property('sensors.ais.fromBow.value', 147.0)
     tree.should.have.nested.property('sensors.ais.fromCenter.value', 8)
-    tree.should.have.nested.property('communication.callsignVhf.value', '3FJJ4')
     delete tree.design.aisShipType
     //TODO enable when sensors.ais.class is in the schema
     //tree.should.be.validSignalKVesselIgnoringIdentity