Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up GitHub workflows #6313

Merged
merged 8 commits into from
Nov 21, 2023
Merged

Clean up GitHub workflows #6313

merged 8 commits into from
Nov 21, 2023

Conversation

Pwuts
Copy link
Member

@Pwuts Pwuts commented Nov 20, 2023

Background

It has been a while since the CI workflows had a clean-up. There are multiple issues, including a security issue (thanks @elad-pticha), across multiple workflows.

TODO:

  • add specifics
  • complete the clean-up
    • delete legacy benchmarks.yml

Changes 🏗️

  • ci: Mitigate security issues in autogpt-ci.yml
  • ci: Simplify steps in autogpt-ci.yml workflow using GitHub CLI
  • ci: Fix issues in workflows

PR Quality Scorecard ✨

  • Have you used the PR description template?   +2 pts
  • Is your pull request atomic, focusing on a single change?   +5 pts
  • Have you linked the GitHub issue(s) that this PR addresses?   +5 pts
  • Have you documented your changes clearly and comprehensively?   +5 pts
  • Have you changed or added a feature?   -4 pts
    • Have you added/updated corresponding documentation?   +4 pts
    • Have you added/updated corresponding integration tests?   +5 pts
  • Have you changed the behavior of AutoGPT?   -5 pts
    • Have you also run agbenchmark to verify that these changes do not regress performance?   +10 pts

- Remove unnecessary pull_request_target paths and related variables and config
- Set permissions for contents to read only
- Simplify step in 'autogpt-ci.yml' by using GitHub CLI instead of API for adding label and comment functionality
- Replace curl command with 'gh issue edit' to add "behaviour change" label to the pull request
- Replace gh api command with 'gh issue comment' to leave a comment about the changed behavior of AutoGPT in the pull request
- Move environment variable definition to top level in benchmark-ci.yml (because the other job also needs it)
- Removed invalid 'branches: [hackathon]' restriction in hackathon.yml workflow
- Removed redundant 'ref' and 'repository' fields in the 'checkout' step of both workflows.
@Pwuts Pwuts requested a review from a team as a code owner November 20, 2023 23:16
@Pwuts Pwuts added Security 🛡️ ci code quality ⬆️ PRs that improve code quality labels Nov 20, 2023
@Pwuts Pwuts self-assigned this Nov 20, 2023
Copy link

netlify bot commented Nov 20, 2023

Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit fde8c4c
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/655c7b68cb46980008ede579
😎 Deploy Preview https://deploy-preview-6313--auto-gpt-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added size/l and removed size/m labels Nov 20, 2023
ntindle
ntindle previously approved these changes Nov 20, 2023
- Add triggers to run CI workflows when they are edited.
- Update the paths for the CI workflows in the trigger configuration.
- Removed unnecessary blank lines in report_types.py
- Fixed string quotes in challenge.py to maintain consistency
- Update task description in `data.json` file for the password generator challenge to clarify the input requirements and error handling.
- This change is made in an attempt to make the Benchmark CI pass.
@Pwuts Pwuts requested a review from a team November 21, 2023 09:04
- Fix the behavior of the reference password_generator.py to align with the task description
- Use default password length 8 instead of a random length in the generate_password function
- Retrieve the password length from the command line arguments if "--length" is provided, else set it to 8
@Pwuts Pwuts merged commit b106a61 into master Nov 21, 2023
11 of 17 checks passed
@Pwuts Pwuts deleted the clean-up-github-workflows branch November 21, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants