Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Provider name enum being used instead of value #9216

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

ntindle
Copy link
Member

@ntindle ntindle commented Jan 7, 2025

Webhooks are broken

Changes πŸ—οΈ

Swaps the way we fill webhooks into strings

Checklist πŸ“‹

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • Manually test creating a webhook with Github and Compass

@ntindle ntindle requested a review from a team as a code owner January 7, 2025 20:13
@ntindle ntindle requested review from Swiftyos and Bentlybro and removed request for a team January 7, 2025 20:13
Copy link

qodo-merge-pro bot commented Jan 7, 2025

PR Reviewer Guide πŸ”

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 πŸ”΅βšͺβšͺβšͺβšͺ
πŸ§ͺΒ No relevant tests
πŸ”’Β No security concerns identified
⚑ Recommended focus areas for review

Test Coverage

There is a TODO comment requesting test coverage for the webhook URL format, but no tests were added in this PR. Consider adding tests to validate the webhook URL structure.

# TODO: add test to assert this matches the actual API route

@github-actions github-actions bot added the platform/backend AutoGPT Platform - Back end label Jan 7, 2025
Copy link

netlify bot commented Jan 7, 2025

βœ… Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
πŸ”¨ Latest commit 39b3336
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/677d8afb06e2240008ff12f8

@github-actions github-actions bot added the size/s label Jan 7, 2025
@ntindle ntindle requested a review from Pwuts January 7, 2025 20:14
Copy link

netlify bot commented Jan 7, 2025

βœ… Deploy Preview for auto-gpt-docs ready!

Name Link
πŸ”¨ Latest commit 39b3336
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/677d8afbc7ad4d00087667d5
😎 Deploy Preview https://deploy-preview-9216--auto-gpt-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ntindle ntindle enabled auto-merge January 7, 2025 20:17
@ntindle ntindle added this pull request to the merge queue Jan 7, 2025
Merged via the queue into dev with commit 4115f65 Jan 7, 2025
19 checks passed
@ntindle ntindle deleted the fix/providername-being-used-for-webhooks-as-enum branch January 7, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants