Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if linear is enabled before showing blocks #9338

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

ntindle
Copy link
Member

@ntindle ntindle commented Jan 26, 2025

Linear blocks show up even if oauth isn't configured

Changes ๐Ÿ—๏ธ

disables the linear blocks if oauth isn't configured

Checklist ๐Ÿ“‹

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • checked block list with and without oauth configured

@ntindle ntindle requested a review from a team as a code owner January 26, 2025 14:54
@ntindle ntindle requested review from Swiftyos and kcze and removed request for a team January 26, 2025 14:54
Copy link

PR Reviewer Guide ๐Ÿ”

Here are some key observations to aid the review process:

โฑ๏ธย Estimated effort to review: 1 ๐Ÿ”ตโšชโšชโšชโšช
๐Ÿงชย No relevant tests
๐Ÿ”’ย No security concerns identified
โšกย No major issues detected

Copy link

netlify bot commented Jan 26, 2025

โœ… Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
๐Ÿ”จ Latest commit 134efb3
๐Ÿ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/67964ca4ffafe000088e282b

Copy link

netlify bot commented Jan 26, 2025

โœ… Deploy Preview for auto-gpt-docs ready!

Name Link
๐Ÿ”จ Latest commit 134efb3
๐Ÿ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/67964ca4a1e81f0009f79005
๐Ÿ˜Ž Deploy Preview https://deploy-preview-9338--auto-gpt-docs.netlify.app
๐Ÿ“ฑ Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@majdyz majdyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
So we are not allowing user manually configuring the linear creds?

@ntindle ntindle added this pull request to the merge queue Jan 26, 2025
Merged via the queue into dev with commit 996efaf Jan 26, 2025
21 checks passed
@ntindle ntindle deleted the fix-linear-disable-status branch January 26, 2025 15:20
waterstark pushed a commit to waterstark/AutoGPT that referenced this pull request Jan 30, 2025
โ€ฆavitas#9338)

<!-- Clearly explain the need for these changes: -->
Linear blocks show up even if oauth isn't configured

### Changes ๐Ÿ—๏ธ
disables the linear blocks if oauth isn't configured

<!-- Concisely describe all of the changes made in this pull request:
-->

### Checklist ๐Ÿ“‹

#### For code changes:
- [x] I have clearly listed my changes in the PR description
- [x] I have made a test plan
- [x] I have tested my changes according to the test plan:
  <!-- Put your test plan here: -->
  - [x] checked block list with and without oauth configured
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants