Skip to content

Commit

Permalink
fix(tests): reverting to a previous version of rollup, chai wasn't wo…
Browse files Browse the repository at this point in the history
…rking otherwise

That bug was so long to find, the newest version of rollup doesn't compile chai properly, causing
the test plugin to immeditaly crash when loading. I don't know if this will get fixed, or I will
have to change my bundler
  • Loading branch information
SilentVoid13 committed Sep 28, 2021
1 parent 57cfdf3 commit 53fd2c1
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 29 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"chai-as-promised": "^7.1.1",
"cz-conventional-changelog": "^3.3.0",
"obsidian": "^0.12.16",
"rollup": "^2.57.0",
"rollup": "2.53.0",
"standard-version": "^9.3.1",
"ts-node": "^9.1.1",
"tslib": "^2.3.1",
Expand Down
52 changes: 26 additions & 26 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions tests/main.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export default class TestTemplaterPlugin extends Plugin {
for (const plugin_name of Object.keys(this.app.plugins.plugins)) {
if (plugin_name !== PLUGIN_NAME && plugin_name !== this.manifest.id) {
// @ts-ignore
this.app.plugins.plugins[plugin_name].unload();
await this.app.plugins.plugins[plugin_name].unload();
}
}
}
Expand All @@ -79,7 +79,7 @@ export default class TestTemplaterPlugin extends Plugin {
for (const plugin_name of Object.keys(this.app.plugins.plugins)) {
if (plugin_name !== PLUGIN_NAME && plugin_name !== this.manifest.id) {
// @ts-ignore
this.app.plugins.plugins[plugin_name].load();
await this.app.plugins.plugins[plugin_name].load();
}
}
}
Expand Down

0 comments on commit 53fd2c1

Please sign in to comment.