Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a basic date picker modal #1098

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AB1908
Copy link
Collaborator

@AB1908 AB1908 commented Apr 22, 2023

Preview:

tp.date.date_picker(
    title: string,
    format: string,
    throw_on_cancel: boolean,
) => Promise<string>

image

Tasks left:

  • Add tests
  • Fix CSS
  • Add docs
  • Add enter callback handler

Notes:

  • I chose to add this under tp.date since it seems to fit in nicely.
  • How can I make a release on my repo so that I can continue to use it via BRAT? It appears the workflow needs me to merge this into main and Obsidian also looks for the package.json in master and incrementing the version number on another package would cause the regular installation to fail. I committed it to my personal branch since once it's merged, it's easier to pull in the new master rather than having to rebase or deal with other shenanigans.

@AB1908 AB1908 force-pushed the date-picker-modal branch from 1efc9fb to b6099a7 Compare April 22, 2023 16:28
@Pritoj
Copy link

Pritoj commented Sep 12, 2024

Is there any reason this is not merged yet?

@Zachatoo
Copy link
Collaborator

I'm interested in reviewing this. @AB1908 is this ready for review? I thought I pulled this down about a year ago and it wasn't working, but I could easily be misremembering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants