Fix used_at casting to date in sms code verification

SimPaypl · Nov 8, 2022 · daaab55 · daaab55
1 parent 169f19a
commit daaab55
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/lib/payments/directbilling.d.ts b/lib/payments/directbilling.d.ts
@@ -20,7 +20,7 @@ export declare class DirectBilling {
     getTransactionsPaginated(serviceId: number, page?: number, pageSize?: number): Promise<PaginatedResponse<PartialDbTransaction>>;
     getTransaction(serviceId: number, transactionId: string): Promise<DbTransaction | undefined>;
     createTransaction(serviceId: number, key: string, request: DbTransactionRequest): Promise<DbGenerationResponse | undefined>;
-    checkNotification(key: string, body: any): DbTransaction | undefined;
+    checkNotification(key: string, body: any): DbNotificationRequest | undefined;
     generateSignature(key: string, request: DbTransactionRequest): string;
     generateSignatureNotification(key: string, request: DbNotificationRequest): string;
 }
diff --git a/lib/payments/sms.js b/lib/payments/sms.js
@@ -185,7 +185,9 @@ class Sms {
     verifySmsCode(serviceId, code, number) {
         return __awaiter(this, void 0, void 0, function* () {
             const response = (yield this.client.post(`/${serviceId}`, { code, number })).data.data;
-            response.used_at = new Date(response.used_at.replace(' ', 'T'));
+            if (response.used_at) {
+                response.used_at = new Date(response.used_at.replace(' ', 'T'));
+            }
             return response;
         });
     }

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "simpay-typescript-api",
   "author": "Rafał Więcek",
-  "version": "2.2.0",
+  "version": "2.2.1",
   "description": "SimPay.pl API",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",

diff --git a/src/payments/sms.ts b/src/payments/sms.ts
@@ -209,7 +209,9 @@ export class Sms {
     async verifySmsCode(serviceId: number, code: string, number?: number): Promise<VerificationResponse | undefined> {
         const response = (await this.client.post(`/${serviceId}`, { code, number })).data.data;
 
-        response.used_at = new Date(response.used_at.replace(' ', 'T'));
+        if( response.used_at ) {
+            response.used_at = new Date(response.used_at.replace(' ', 'T'));
+        }
 
         return response;
     }