-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: 🐛 Fixed TitleAlign Issue #459
base: master
Are you sure you want to change the base?
Conversation
Added titleAlignment and descriptionAlignment parameters to align title and description within the tooltip widget Renamed parameters titleAlignment to titleTextAlign and descriptionAlignment to descriptionTextAlign
@@ -11,6 +11,9 @@ A Flutter package allows you to Showcase/Highlight your widgets step by step. | |||
|
|||
![The example app running in Android](https://raw.githubusercontent.com/SimformSolutionsPvtLtd/flutter_showcaseview/master/preview/showcaseview.gif) | |||
|
|||
## Migration guide for release 4.0.0 | |||
Renamed parameters `titleAlignment` to `titleTextAlign` and `descriptionAlignment` to `descriptionTextAlign` to correspond it more with the TextAlign property |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also mention that the existing variables' behaviour/purpose has been changed.
@@ -252,13 +254,25 @@ class Showcase extends StatefulWidget { | |||
/// Defaults to 7. | |||
final double toolTipSlideEndDistance; | |||
|
|||
/// Title alignment within tooltip widget |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add widget word in there?
/// Title alignment within tooltip widget | |
/// Title widget alignment within tooltip widget |
@@ -439,44 +443,52 @@ class _ToolTipWidgetState extends State<ToolTipWidget> | |||
: CrossAxisAlignment.center, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see if this is still required after the usage of Align
as parent of the children.
@@ -70,7 +72,7 @@ class ToolTipWidget extends StatefulWidget { | |||
required this.offset, | |||
required this.screenSize, | |||
required this.title, | |||
required this.titleAlignment, | |||
required this.titleTextAlign, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please put this with the other text align and alignment property below?
Description
titleAlignment
anddescriptionAlignment
parameters to align title and description within the tooltip widgettitleAlignment
totitleTextAlign
anddescriptionAlignment
todescriptionTextAlign
Checklist
fix:
,feat:
,docs:
etc).docs
and added dartdoc comments with///
.examples
ordocs
.Breaking Change?
Related Issues
Closes #457