Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add /bin/ to .eslintignore #120

Merged
merged 1 commit into from
Jul 18, 2024
Merged

chore: Add /bin/ to .eslintignore #120

merged 1 commit into from
Jul 18, 2024

Conversation

SimonAlling
Copy link
Owner

@SimonAlling SimonAlling commented Jul 18, 2024

The reason it works without it is that the sole .ts file created in bin/ by npm run build contains nothing more than this:

#!/usr/bin/env node
export {};

So it basically just happens to pass our ESLint config. But it makes sense to ignore all compiled files.

@SimonAlling SimonAlling marked this pull request as ready for review July 18, 2024 20:49
@SimonAlling SimonAlling merged commit 283b175 into master Jul 18, 2024
5 checks passed
@SimonAlling SimonAlling deleted the eslintignore-bin branch July 18, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant