Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Upgrade to TypeScript 4.4 #146

Merged
merged 1 commit into from
Jul 23, 2024
Merged

build: Upgrade to TypeScript 4.4 #146

merged 1 commit into from
Jul 23, 2024

Conversation

SimonAlling
Copy link
Owner

@SimonAlling SimonAlling commented Jul 23, 2024

This will enable upgrading to Jest 26 (#144; see #145).

Breaking?

See #145 for details on why this should possibly be considered a breaking change.

I consider it backward compatible, because I don't think any consumer is broken by it. Notably, building with and without this PR in different Git working trees and using git diff --no-index to diff the emitted code (build/ and lib/) reveals that the only difference is that some expressions in .js files are transformed from foo to (0, foo).

@SimonAlling SimonAlling marked this pull request as ready for review July 23, 2024 16:24
@SimonAlling SimonAlling merged commit 9f27ebb into master Jul 23, 2024
8 checks passed
@SimonAlling SimonAlling deleted the typescript-4.4 branch July 23, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant