Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional parameters fft_based_translation_initialization #39

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

blowekamp
Copy link
Member

Add required_fraction_of_overlapping_pixels to specify minimum overlapping of images. Defaulting to 0 to preserve compatibility.

Add initial_transform and masked_pixel_value.

@blowekamp blowekamp requested a review from zivy February 2, 2024 18:41
@blowekamp
Copy link
Member Author

@zivy This PR changes the required version of SimpleITK to 2.3.0 for the number of required pixels overlap parameter for the FFTNormalizedCorelation. Do you thing it is ok to update the require version of SimpleITK like that?

Copy link
Member

@zivy zivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor spelling and commented out code that should be removed.

SimpleITK/utilities/fft.py Outdated Show resolved Hide resolved
SimpleITK/utilities/fft.py Outdated Show resolved Hide resolved
@zivy
Copy link
Member

zivy commented Feb 2, 2024

At this early stage of the utilities package life (<v0.5) I think the change requiring SimpleITK 2.3.0 is fine.

@blowekamp blowekamp force-pushed the update_fft_initialize branch 2 times, most recently from eb234e9 to b7c20df Compare February 5, 2024 15:21
Add required_fraction_of_overlapping_pixels to specify minimum
overlapping of images. Defaulting to 0 to preserve compatibility.

Add initial_transform and masked_pixel_value.
@blowekamp blowekamp marked this pull request as ready for review February 6, 2024 16:23
@blowekamp blowekamp changed the title Add oprional parameters fft_based_translation_initialization Add optional parameters fft_based_translation_initialization Feb 8, 2024
@zivy zivy merged commit 431d7c2 into SimpleITK:main Feb 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants