Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDK client library #49

Merged
merged 58 commits into from
Jan 15, 2024
Merged

Add SDK client library #49

merged 58 commits into from
Jan 15, 2024

Conversation

sangaline
Copy link
Contributor

@sangaline sangaline commented Jan 12, 2024

This adds a basic sketch of the SDK client library. I mostly mirrored the Python SDK method structure, but would like to diverge from that to make things more ergonomic. Most of the complexity here isn't really in the SDK itself, but rather in the testing framework around it. Making circuit creation requests mockable with Nock required a MITM proxy and some fairly sophisticated request parsing to handle multipart form payloads and the non-determinism of the gzipped tarballs. The circuit creation implementation was also a little tricky in terms of supporting both browsers and node. With these more difficult parts figured out, it shouldn't be too bad to refactor things and clean them up.

Note that the docstrings right now are pure fluff, I barely cleaned up what chatgpt output. I wanted to get something there so that I can test/develop the documentation build and then I'll clean these up and write real docs as I refactor the SDK's API.

@sangaline sangaline merged commit 36b4c10 into main Jan 15, 2024
2 checks passed
@sangaline sangaline deleted the ews-start-sdk branch January 15, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant