Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update noir scaffold version field #71

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

katiemckeon
Copy link
Contributor

Previously our sindri init scaffold built a noir circuit with Nargo.toml specifying the compiler version as 0.19.3. Since the sindri.json does not contain a noirVersion field, the most recent API release will assume you intend to use 0.23.0. This will cause a Nargo compilation error.

This PR introduces a noirVersion field supplied by the user to pass into the Nargo.toml and sindri.json. The options for this field match our current support.

Copy link
Contributor

@sangaline sangaline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sangaline sangaline assigned katiemckeon and unassigned sangaline Feb 12, 2024
@katiemckeon katiemckeon merged commit 9abae31 into main Feb 12, 2024
5 checks passed
@katiemckeon katiemckeon deleted the klm-update-noir-scaffold branch February 12, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants