Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove includeProofInput option #93

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Remove includeProofInput option #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9ef11b
Regenerate the internal API client.
sangaline Mar 18, 2024
fa2834f
Update the `proofDetail()` call to exclude proof input.
sangaline Mar 18, 2024
5d2d23e
Update test fixtures.
sangaline Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/api/ApiClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export class ApiClient {
constructor(config?: Partial<OpenAPIConfig>, HttpRequest: HttpRequestConstructor = AxiosHttpRequest) {
this.request = new HttpRequest({
BASE: config?.BASE ?? 'https://sindri.app',
VERSION: config?.VERSION ?? '1.6.9',
VERSION: config?.VERSION ?? '1.6.11',
WITH_CREDENTIALS: config?.WITH_CREDENTIALS ?? false,
CREDENTIALS: config?.CREDENTIALS ?? 'include',
TOKEN: config?.TOKEN,
Expand Down
2 changes: 1 addition & 1 deletion src/lib/api/core/OpenAPI.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export type OpenAPIConfig = {

export const OpenAPI: OpenAPIConfig = {
BASE: "https://sindri.app",
VERSION: "1.6.9",
VERSION: "1.6.11",
WITH_CREDENTIALS: false,
CREDENTIALS: "include",
TOKEN: undefined,
Expand Down
4 changes: 0 additions & 4 deletions src/lib/api/models/ProofInfoResponse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,6 @@ export type ProofInfoResponse = {
* Total size of stored file(s) in bytes.
*/
file_size?: number;
/**
* The private/public inputs to the circuit.
*/
proof_input?: Record<string, any>;
/**
* The succinct argument(s) of knowledge.
*/
Expand Down
5 changes: 1 addition & 4 deletions src/lib/api/services/CircuitsService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ export class CircuitsService {
* Circuit Proofs
* Return list of ProofInfoResponse for proofs of circuit_id related to team.
* @param circuitId
* @param includeProofInput
* @param includeProof
* @param includePublic
* @param includeSmartContractCalldata
Expand All @@ -129,7 +128,6 @@ export class CircuitsService {
*/
public circuitProofs(
circuitId: string,
includeProofInput: boolean = false,
includeProof: boolean = false,
includePublic: boolean = false,
includeSmartContractCalldata: boolean = false,
Expand All @@ -142,7 +140,6 @@ export class CircuitsService {
circuit_id: circuitId,
},
query: {
include_proof_input: includeProofInput,
include_proof: includeProof,
include_public: includePublic,
include_smart_contract_calldata: includeSmartContractCalldata,
Expand All @@ -168,7 +165,7 @@ export class CircuitsService {
circuitId: string,
formData: {
/**
* JSON-serialized string for the proof input.
* A string representing proof input which may be formatted as JSON for any framework. Noir circuits optionally accept TOML formatted proof input.
*/
proof_input: string;
/**
Expand Down
6 changes: 0 additions & 6 deletions src/lib/api/services/ProofsService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ export class ProofsService {
/**
* Proof List
* Return list of ProofInfoResponse for proofs related to team.
* @param includeProofInput
* @param includeProof
* @param includePublic
* @param includeSmartContractCalldata
Expand All @@ -23,7 +22,6 @@ export class ProofsService {
* @throws ApiError
*/
public proofList(
includeProofInput: boolean = false,
includeProof: boolean = false,
includePublic: boolean = false,
includeSmartContractCalldata: boolean = false,
Expand All @@ -33,7 +31,6 @@ export class ProofsService {
method: "GET",
url: "/api/v1/proof/list",
query: {
include_proof_input: includeProofInput,
include_proof: includeProof,
include_public: includePublic,
include_smart_contract_calldata: includeSmartContractCalldata,
Expand All @@ -50,7 +47,6 @@ export class ProofsService {
* Proof Detail
* Get info for existing proof
* @param proofId
* @param includeProofInput
* @param includeProof
* @param includePublic
* @param includeSmartContractCalldata
Expand All @@ -60,7 +56,6 @@ export class ProofsService {
*/
public proofDetail(
proofId: string,
includeProofInput: boolean = true,
includeProof: boolean = true,
includePublic: boolean = true,
includeSmartContractCalldata: boolean = false,
Expand All @@ -73,7 +68,6 @@ export class ProofsService {
proof_id: proofId,
},
query: {
include_proof_input: includeProofInput,
include_proof: includeProof,
include_public: includePublic,
include_smart_contract_calldata: includeSmartContractCalldata,
Expand Down
1 change: 0 additions & 1 deletion src/lib/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,7 +654,6 @@ export class SindriClient {
while (true) {
response = await this._client.proofs.proofDetail(
createResponse.proof_id,
true, // includeProofInput
true, // includeProof
true, // includePublic
includeSmartContractCalldata, // includeSmartContractCalldata
Expand Down
42,758 changes: 24,625 additions & 18,133 deletions test/fixtures/browser.test.ts.json
View file
Open in desktop

Large diffs are not rendered by default.

Loading