Make RecipeBookManagerMixin clientside #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class isn't marked as OnlyIn(Dist.CLIENT), but it is in NeoForge's client package. It also references many classes which are marked as client, so loading this mixin would cause issues on a server. This is normally not noticeable, but if the mixin is forcibly loaded via a mixin audit it will crash.
Su5eD
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class isn't marked as OnlyIn(Dist.CLIENT), but it is in NeoForge's client package. It also references many classes which are marked as client, so loading this mixin would cause issues on a server.
Normally, this is not noticeable since this class won't be accessed from the server. But it is still wrong and when a mixin audit is run this will cause a crash.