✨ Compute php version #16
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hardcoded phpversion may be outdated as we use the latest available wasm.
homersimpsons
force-pushed
the
chore/compute-phpversion
branch
from
0ab9d8e to
53db8dc
Compare
homersimpsons
commented
Jul 25, 2024
Comment on lines
+222
to
+227
| // Compute version | ||
| const phpVersionRunner = new PhpWeb() | ||
| phpVersionRunner.addEventListener('output', (event) => { | ||
| $('#phpversion').textContent = "Output for php " + event.detail[0] | ||
| }); | ||
| phpVersionRunner.run('<?php echo phpversion();') |
There was a problem hiding this comment.
For now we are forced to run php to get this information.
In the future we will be able to use PhpWeb.phpVersion
Suggested change
| // Compute version | |
| const phpVersionRunner = new PhpWeb() | |
| phpVersionRunner.addEventListener('output', (event) => { | |
| $('#phpversion').textContent = "Output for php " + event.detail[0] | |
| }); | |
| phpVersionRunner.run('<?php echo phpversion();') | |
| // Set PHP version in the UI | |
| $('#phpversion').textContent = "Output for php " + PhpWeb.phpVersion | |
| phpVersionRunner.run('<?php echo phpversion();') |
We can "opt-in" to this by using https://cdn.jsdelivr.net/npm/[email protected]/PhpWeb.mjs instead of the current latest version v0.0.8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hardcoded phpversion may be outdated as we use the latest available wasm.