Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sn 568 v1 #273

Open
wants to merge 109 commits into
base: develop
Choose a base branch
from
Open

Sn 568 v1 #273

wants to merge 109 commits into from

Conversation

cuongho2
Copy link

Pre-flight checklist

  • Unit tests for all non-trivial changes
  • Tested locally
  • Updated wiki

@choipd
resolve issue #1
18194cb
@choipd
Merge pull request #3 from choipd/1-add-human-item-buttons
c62d693 
resolve issue #1
@choipd
humans, items added
69a746d
@choipd
Merge branch 'develop' into 2-label-header-customize
66670ca
@choipd
라벨 헤더에 구분하는 것 넣기
5e606f1
@choipd
Merge pull request #4 from choipd/2-label-header-customize
e154bdb 
2 label header customize
@choipd
tag button
af64cbd
@choipd
item attribute select WIP
6549fc3
@choipd
human info 저장하는 기능까지 만들었음
fb4fc87
@choipd
지울 때 humans, items 에도 반영
22ace1e
@choipd
export json 추가
a898a45
@choipd
import annotation 기능 완료
18771da
@choipd
메인 카테고리 변경시 서브카테고리 변경
e3c8ddf
@choipd
휴먼 선택하면 거기에 맞춰서 ITEM생성시 human_id 맵핑
e5a25f3
@choipd
Merge pull request #6 from choipd/5-label-attribute-form
37d45ea 
5 label attribute form
@choipd
now we don't need labels.txt
9684733
@choipd
adding guide images
a47d00b
@choipd
send json
e6b4a53
@choipd
Guide style integration, importer integration
8f1b972
@choipd
save auth data in localstorage
d6c572c
@choipd
logout
cac9636
@choipd
logout
ba5c750
@choipd
style name
b24455a
@choipd
make subcategory control main
9bec859
@choipd
스타일 코드 다시 맞추는 작업중
0cf2707
@choipd
replace style image
0ba2cc0
@choipd
베트남어 지원
0c3e5d2
@choipd
label attribute bug fix
8d8be5d
@choipd
loading image bug fix
2a0910f
@choipd
add vietnamese in menu text
51ea77b
@rasyidf
Copy link
Contributor

rasyidf commented Aug 24, 2022

I'll help to recap @cuongho2 changes,

this has many good changes, unfortunately it changed too much without proper details of feature changed. and so much additional Image (1229 Image, :D )

@SkalskiP
Copy link
Owner

@rasyidf I'm pretty sure that PR was not intended to be submitted into our repo.

@cuongho2 Am I correct?

@SkalskiP
Copy link
Owner

SkalskiP commented Sep 6, 2022

I need to say that I'm getting more and more confused by that PR.

cuongho2 and others added 7 commits September 7, 2022 09:22
@cuongho2
change to previous code format
9f62a83
@cuongho2
change format to previous
2f4294b
@choipd
12 lock attributes (#14)
d559213 
* #12 Move rendering item to the atrributeSelect

* #12 Bug fix when select unknown as human ID

* #13 hide unknown in categories
@choipd
15 visualize task status (#16)
1be11de 
* #15 visualize taskStatus done

* resolved #15 show tasks performance popup
@choipd
resolved #17 add summary in the performance popup (#18)
d8a6581
@choipd
resolved #19 (#20)
f380620
@cuongho2
fix conflict
a137fdd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cuongho2 @rasyidf @SkalskiP @choipd @quoccuong03 @mjfruits1