adding a method to get only the adaptors that are worth computing #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we compute with lora adapters, there are some situations where we can just prefer to skip the computation. One of these is if
r==0
(which was already addressed) and one is when thenscaling
parameter (or equivalently thelora_alpha
param) is zero. This was only addressed partially.Here we centralize the logic to identify only the adapter (names) that are worthwile for compute into the
LoraLayer
class, so all classes that extend it can have a consiste way of identifying which layers to run computation for