upload: Support Update-Pr-Body as a commit tag

This allows you to manually specify one or more prs
as no-update while maintaining the default option for
all other prs. (and vise versa)

Fixes: #140
nefdsfadseeee
fd

revup/topic_stack.py

@@ -48,6 +48,7 @@ def format_remote_branch(uploader: str, base_branch: str, topic: str) -> str:
 TAG_RELATIVE = "relative"
 TAG_RELATIVE_BRANCH = "relative-branch"
 TAG_UPLOADER = "uploader"
+TAG_UPDATE_PR_BODY = "update-pr-body"
 VALID_TAGS = {
     TAG_BRANCH,
     TAG_LABEL,
@@ -57,6 +58,7 @@ def format_remote_branch(uploader: str, base_branch: str, topic: str) -> str:
     TAG_ASSIGNEE,
     TAG_TOPIC,
     TAG_UPLOADER,
+    TAG_UPDATE_PR_BODY,
 }
 
 RE_COMMIT_LABEL = re.compile(r"^(?P<label1>[a-zA-Z\-_0-9]+):.*|^\[(?P<label2>[a-zA-Z\-_0-9]+)\].*")
@@ -468,6 +470,14 @@ async def populate_reviews(
             if len(topic.tags[TAG_UPLOADER]) > 1:
                 raise RevupUsageException(f"Can't specify more than one uploader for topic {name}!")
 
+            if TAG_UPDATE_PR_BODY in topic.tags:
+                if len(topic.tags[TAG_UPDATE_PR_BODY]) > 1 or min(
+                    topic.tags[TAG_UPDATE_PR_BODY]
+                ).lower() not in {"true", "false"}:
+                    raise RevupUsageException(
+                        f"Invalid tags for update-pr-body: {topic.tags[TAG_UPDATE_PR_BODY]}"
+                    )
+
             relative_topic = ""
             if force_relative_chain and seen_topics:
                 relative_topic = list(seen_topics)[-1]
@@ -1033,7 +1043,7 @@ async def query_github(self) -> None:
 
     def populate_update_info(
         self,
-        update_pr_body: bool,
+        update_pr_body_arg: bool,
     ) -> None:
         """
         Populate information necessary to do PR creation / update in github.
@@ -1106,6 +1116,11 @@ def populate_update_info(
                     topic.tags[TAG_ASSIGNEE], self.names_to_logins
                 ).difference(review.pr_info.assignees)
 
+                if TAG_UPDATE_PR_BODY in topic.tags:
+                    update_pr_body = min(topic.tags[TAG_UPDATE_PR_BODY]).lower() == "true"
+                else:
+                    update_pr_body = update_pr_body_arg
+
                 if review.pr_info.baseRef != review.remote_base:
                     review.pr_update.baseRef = review.remote_base
                 if update_pr_body and review.pr_info.body != body: