Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amend: Force editing if inserting instead of throwing error #120

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

jerry-skydio
Copy link
Collaborator

If a user has configured edit=False but specifies --insert,
the intention is clear enough that they do in fact want to edit.
We can automatically assume this without throwing an error and
forcing them to type out --edit

@jerry-skydio
Copy link
Collaborator Author

Reviews in this chain:
#120 amend: Force editing if inserting instead of throwing error

@jerry-skydio
Copy link
Collaborator Author

jerry-skydio commented Jul 19, 2023

# head base diff date summary
0 dd2402e2 62448640 diff Jul 18 19:31 PM 1 file changed, 1 insertion(+), 2 deletions(-)
1 11455bc0 161e9b77 diff Jul 27 13:33 PM 1 file changed, 2 insertions(+), 2 deletions(-)

Copy link
Contributor

@aaron-skydio aaron-skydio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good for the docs for --insert to mention that --edit is implied?

If a user has configured edit=False but specifies --insert,
the intention is clear enough that they do in fact want to edit.
We can automatically assume this without throwing an error and
forcing them to type out --edit
@jerry-skydio
Copy link
Collaborator Author

good poing

@jerry-skydio jerry-skydio merged commit aadd1ce into main Jul 27, 2023
5 checks passed
@jerry-skydio jerry-skydio deleted the jerry/revup/main/yesedit branch July 27, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants