Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick can fetch base-branch #121

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

aaron-skydio
Copy link
Contributor

Useful if cherry-picking from a relative topic chain.

It would be nice if we could automatically cherry-pick just the commits
from a particular topic without needing to specify the previous topic as
the base-branch, but that would require either fetching "more stuff"
from the remote and doing some guessing, or querying the github API,
both of which are a bit more complicated

Topic: cherry-pick-relative
Reviewers: jerry,brian-k

@aaron-skydio
Copy link
Contributor Author

Reviews in this chain:
#121 Cherry-pick can fetch base-branch

@aaron-skydio
Copy link
Contributor Author

aaron-skydio commented Jul 24, 2023

# head base diff date summary
0 e813ff2a 62448640 diff Jul 24 15:26 PM 1 file changed, 17 insertions(+), 6 deletions(-)
1 e7f59d0e 62448640 diff Jul 24 15:31 PM 1 file changed, 2 insertions(+), 2 deletions(-)

Useful if cherry-picking from a relative topic chain.

It would be nice if we could automatically cherry-pick just the commits
from a particular topic without needing to specify the previous topic as
the base-branch, but that would require either fetching "more stuff"
from the remote and doing some guessing, or querying the github API,
both of which are a bit more complicated

Topic: cherry-pick-relative
Reviewers: jerry,brian-k
@aaron-skydio aaron-skydio force-pushed the aaron/revup/main/cherry-pick-relative branch from e813ff2 to e7f59d0 Compare July 24, 2023 22:31
Copy link
Collaborator

@jerry-skydio jerry-skydio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops i put this review off for way too long

@jerry-skydio jerry-skydio merged commit c4ace45 into main Mar 13, 2024
5 checks passed
@jerry-skydio jerry-skydio deleted the aaron/revup/main/cherry-pick-relative branch March 13, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants