ARGG-946 Add @skyscanner/[email protected] to dependencies (#692

) * ARGG-946 Add @skyscanner/eslint-plugin-rules * Use @skyscanner/[email protected]
Skyscanner · Jan 22, 2024 · d40ec3c · d40ec3c
1 parent b33d72c
commit d40ec3c
Show file tree

Hide file tree

Showing 9 changed files with 18 additions and 181 deletions.
diff --git a/README.md b/README.md
@@ -27,12 +27,6 @@ If your project doesn't use it or it is not installed in the same `package.json`
 }
 ```
 
-## Rules included in this repository
-
-Custom rules are currently wrapped in a locally-installed package.
-This will no longer be needed once the eslint version used accepts objects as shown in
-[custom rules tutorial](https://eslint.org/docs/latest/extend/custom-rule-tutorial#step-8-use-the-plugin-locally).
-
 ## Changelog
 
 [View our up-to-date changelog](./CHANGELOG.md).
diff --git a/eslint-plugin-skyscanner-no-axios/package.json b/eslint-plugin-skyscanner-no-axios/package.json
diff --git a/eslint-plugin-skyscanner-no-axios/src/index.js b/eslint-plugin-skyscanner-no-axios/src/index.js
diff --git a/eslint-plugin-skyscanner-no-axios/src/rules/no-axios.js b/eslint-plugin-skyscanner-no-axios/src/rules/no-axios.js
diff --git a/eslint-plugin-skyscanner-no-axios/src/rules/no-axios.test.js b/eslint-plugin-skyscanner-no-axios/src/rules/no-axios.test.js
diff --git a/index.js b/index.js
@@ -39,14 +39,14 @@ module.exports = {
     'jest-formatting',
     'sort-destructure-keys',
     'typescript-enum',
-    'skyscanner-no-axios',
+    '@skyscanner/rules',
   ],
   rules: {
     'prettier/prettier': 'error',
     'valid-jsdoc': ['error'],
     'backpack/use-tokens': 'error',
     'backpack/use-components': 'off',
-    'skyscanner-no-axios/no-axios': 'error',
+    '@skyscanner/rules/no-axios': 'error',
 
     // This rule is pretty restrictive and we feel this decision should be left to developers to decide on a case by case basis.
     // A file can contain more than one class and still have a single responsibility

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -47,6 +47,7 @@
     "@babel/core": "^7.23.7",
     "@babel/eslint-parser": "^7.23.3",
     "@babel/preset-react": "^7.23.3",
+    "@skyscanner/eslint-plugin-rules": "^1.0.1",
     "@typescript-eslint/eslint-plugin": "^6.19.0",
     "@typescript-eslint/parser": "^6.18.1",
     "colors": "^1.4.0",
@@ -58,7 +59,6 @@
     "eslint-plugin-import": "^2.29.1",
     "eslint-plugin-jest": "^27.6.3",
     "eslint-plugin-jest-formatting": "^3.1.0",
-    "eslint-plugin-skyscanner-no-axios": "file:./eslint-plugin-skyscanner-no-axios",
     "eslint-plugin-jsx-a11y": "^6.8.0",
     "eslint-plugin-prettier": "^5.1.3",
     "eslint-plugin-react": "^7.33.2",

diff --git a/test/package.json b/test/package.json
@@ -17,8 +17,7 @@
     "test:fail-react": "echo 'Expecting failure' && eslint react-fail.tsx; if [ $? -eq 1 ]; then exit 0; fi",
     "test:fail-import-order": "echo 'Expecting failure' && eslint order-fail.jsx; if [ $? -eq 1 ]; then exit 0; fi",
     "test:fail-no-axios": "echo 'Expecting failure' && eslint no-axios-fail.jsx; if [ $? -eq 1 ]; then exit 0; fi",
-    "test:skyscanner-no-axios": "cd ../eslint-plugin-skyscanner-no-axios; jest",
-    "test": "npm run test:skyscanner-no-axios && npm run test:fail-no-axios && npm run test:pass && npm run test:fail-jsdoc && npm run test:fail-bpk && npm run test:fail-prettier && npm run test:fail-react && npm run test:fail-import-order"
+    "test": "npm run test:pass && npm run test:fail-no-axios &&npm run test:fail-jsdoc && npm run test:fail-bpk && npm run test:fail-prettier && npm run test:fail-react && npm run test:fail-import-order"
   },
   "dependencies": {
     "prop-types": "^15.5.10",