Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @skyscanner/bpk-foundations-web from 17.9.0 to 18.1.0 #137

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 10, 2024

Bumps @skyscanner/bpk-foundations-web from 17.9.0 to 18.1.0.

Changelog

Sourced from @​skyscanner/bpk-foundations-web's changelog.

2024-06-04

@skyscanner/bpk-foundations-web: 18.0.0 => 18.1.0

Added:

  • Added new letter-spacing-hero and letter-spacing-display tokens.

2024-05-31

@skyscanner/bpk-foundations-web: 17.14.0 => 18.0.0

Breaking:

  • Updated typography tokens to support updated typography
    • Changed $bpk-line-height-xxxxxl from 4.5rem to 4rem for Hero 4 update
    • Changed $bpk-line-height-6-xl from 5.25rem to 4.75rem for Hero 3 update

Added:

  • Added tokens for BpkSegmentedControl

@skyscanner/bpk-foundations-android: 7.11.0 => 7.12.0 @skyscanner/bpk-foundations-common: 6.11.0 => 6.12.0 @skyscanner/bpk-foundations-ios: 6.11.0 => 6.12.0 @skyscanner/bpk-foundations-react-native: 4.11.0 => 4.12.0

Added:

  • Added tokens for BpkSegmentedControl

2024-05-20

Added: @skyscanner/bpk-foundations-web: 17.13.0 => 17.14.0

  • Add Noto in font-family as fallback for the Larken font

2024-05-14

Added: @skyscanner/bpk-foundations-web: 17.12.0 => 17.13.0

  • Adding a new token for font-weight of 300 as $bpk-font-weight-light

2024-05-13

Added: @skyscanner/bpk-foundations-web: 17.11.0 => 17.12.0

  • Adding new Larken font-family to support the new Editorial font.

2024-04-26

Added: @skyscanner/bpk-foundations-web:

... (truncated)

Commits
  • 607e419 Publish
  • 2e4a0bd [WALL-1807] Add new hero & display letter spacings (#327)
  • b48739b [skip ci]: Update changelog post publish
  • 2336423 Publish
  • d4e253e LUNA-1231: addtokens segmented control (#325)
  • 4c32c66 [WALL-1807] Change line height tokens for existing typography updates (#324)
  • 9a1bbdc [skip ci]: Update changelog post publish
  • f39d8ac Publish
  • d57f675 [WALL-1371] Update font-family to use Noto as Larken fallback (#321)
  • 2dbe1fb Bump webpack-dev-middleware from 6.1.1 to 6.1.2 (#290)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file major labels Jun 10, 2024
@anambl
Copy link
Contributor

anambl commented Jun 11, 2024

@dependabot rebase

Bumps [@skyscanner/bpk-foundations-web](https://github.com/Skyscanner/backpack-foundations) from 17.9.0 to 18.1.0.
- [Changelog](https://github.com/Skyscanner/backpack-foundations/blob/main/CHANGELOG.md)
- [Commits](https://github.com/Skyscanner/backpack-foundations/compare/@skyscanner/[email protected]...@skyscanner/[email protected])

---
updated-dependencies:
- dependency-name: "@skyscanner/bpk-foundations-web"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/skyscanner/bpk-foundations-web-18.1.0 branch from 40b2a75 to 49393ac Compare June 11, 2024 15:00
@@ -87,13 +87,13 @@ ruleTester.run('use-tokens', useTokens, {
code: `
const styles = StyleSheet.create({
foo: {
color: 'rgba(0, 0, 0, 0.8)',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a new token was added that uses this colour so we got a different error message saying that there's multiple colour tokens matching for this colour

Copy link

@mungodewar mungodewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anambl anambl merged commit 4215cb1 into main Jun 12, 2024
3 checks passed
@anambl anambl deleted the dependabot/npm_and_yarn/skyscanner/bpk-foundations-web-18.1.0 branch June 12, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants