New PoseFrame streaming format #1284
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately including the exception spams the logs a lot, it's best that we don't log it
ButterscotchV
added
Priority: Low
ButterscotchV
force-pushed
the
pfs-format
branch
from
ecf111b to
4b24c22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently AutoBone uses PFR and I've used PFR for debugging before, but the structure of the file is rigid and won't work for streaming to or from a file, which would be very important in testing/diagnosing issues. This new PFS format is based on the old PFR format for easy compatibility and to keep things simple, but make it more usable for the future.
This PR implements PFS and uses it by default in AutoBone, while still supporting the older PFR format. Converting PFR to PFS is very straightforward and most people don't use this feature at all, so I don't think it's necessary to implement conversion further.