Change the registry to use world UUIDs #3672
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have recently run into an issue where a world, when created quickly enough after deletion of a world with the same name, will not store data. I have tested this extensively and narrowed the issue down to this ticker code and this check for the world's existence. Since the ticker code only runs every half second, it does not remove the world from the registry until up to a Slimefun tick later and therefore causes issues in the constructor.
An easy way to recreate this issue is to delete a world and immediately create a new one with the same name.
Proposed changes
This PR changes the registry to use UUIDs instead of the world names themselves. This does not affect the storage location in files and therefore these are not breaking changes.
This may not be the ideal way to do it; it may be better to remove the world from the registry here instead.
Related Issues (if applicable)
No issue opened
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values